Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132650 / 25.04 / Fixing codecov coverage reporting #11114

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 28, 2024

Testing:
Observe that codecov/patch fails with an error now. I will remove dummy code before merge.

@bugclerk bugclerk changed the title NAS-132650: Fixing codecov coverage reporting NAS-132650 / 25.04 / Fixing codecov coverage reporting Nov 28, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (8c8c3c6) to head (72609bc).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11114      +/-   ##
==========================================
+ Coverage   82.28%   82.35%   +0.06%     
==========================================
  Files        1650     1645       -5     
  Lines       57730    57768      +38     
  Branches     5948     5947       -1     
==========================================
+ Hits        47506    47576      +70     
+ Misses      10224    10192      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft marked this pull request as ready for review November 29, 2024 09:30
@undsoft undsoft requested a review from a team as a code owner November 29, 2024 09:30
@undsoft undsoft requested review from bvasilenko and removed request for a team November 29, 2024 09:30
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov failed:

Screenshot 2024-11-29 at 11 33 24

@undsoft undsoft enabled auto-merge (squash) November 29, 2024 10:11
@undsoft undsoft merged commit fcf669d into master Nov 29, 2024
9 checks passed
@undsoft undsoft deleted the NAS-132650 branch November 29, 2024 10:39
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants