Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132751 / 24.10.2 / Cloud Credentials: It is not possible to delete cloud credentials (by AlexKarpov98) #11125

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Dec 2, 2024

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x d1ba4d0e4cea1ca1278445ab0b04b164fcab6e2d

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 625db124477082031b7fa33770e360c67766e392

Testing:

See custom error as an example:

Screen.Recording.2024-12-02.at.11.38.42.mov

Original PR: #11122
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132751

@undsoft
Copy link
Collaborator

undsoft commented Dec 5, 2024

@AlexKarpov98 Don't forget about this PR.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review December 6, 2024 10:26
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 6, 2024 10:26
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team December 6, 2024 10:26
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@6a57500). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #11125   +/-   ##
=====================================================
  Coverage                      ?   79.96%           
=====================================================
  Files                         ?     1572           
  Lines                         ?    51446           
  Branches                      ?     5937           
=====================================================
  Hits                          ?    41138           
  Misses                        ?    10308           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 63b3597 into stable/electriceel Dec 9, 2024
7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132751-24.10.2 branch December 9, 2024 09:14
@bugclerk
Copy link
Contributor Author

bugclerk commented Dec 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants