Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132805 / 24.10.1 / Hide "take snapshot" for TrueCloud backup #11127

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 2, 2024

Changes:

Hides "Take Snapshot" option from the UI as requested in the ticket.

Downstream

Affects Reasoning
Documentation Removes an option from Truecloud Backup form.

@undsoft undsoft requested a review from a team as a code owner December 2, 2024 12:45
@undsoft undsoft requested review from bvasilenko and removed request for a team December 2, 2024 12:45
@bugclerk bugclerk changed the title NAS-132805: Hide "take snapshot" for TrueCloud backup NAS-132805 / 24.10.1 / Hide "take snapshot" for TrueCloud backup Dec 2, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/24.10.1@f07cd08). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/24.10.1   #11127   +/-   ##
==================================================
  Coverage                   ?   79.96%           
==================================================
  Files                      ?     1572           
  Lines                      ?    51458           
  Branches                   ?     5938           
==================================================
  Hits                       ?    41148           
  Misses                     ?    10310           
  Partials                   ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@undsoft undsoft merged commit 1478fb8 into release/24.10.1 Dec 3, 2024
7 checks passed
@undsoft undsoft deleted the NAS-132805 branch December 3, 2024 09:54
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants