Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xattr compat cleanup #16

Merged
9 commits merged into from
Jul 15, 2021
Merged

xattr compat cleanup #16

9 commits merged into from
Jul 15, 2021

Commits on Jul 13, 2021

  1. Improve use of SET_ERROR() in FreeBSD xattrs 

    Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    5c2bd58 View commit details
    Browse the repository at this point in the history

  2. Simplify zfs_deleteextattr_impl 

    We don't need to check if the xattr exists before attempting to delete
it.  This was a carryover from an implementation detail on Linux.

With this simplified, we can also reuse zfs_deleteextattr_impl in
zfs_setextattr_impl.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    8f9a3b4 View commit details
    Browse the repository at this point in the history

  3. Avoid adding Linuxisms in FreeBSD code 

    Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    b4df624 View commit details
    Browse the repository at this point in the history

  4. Add comments where xattr namespace fallbacks occur 

    We want to be able to configure these checks to be skipped, ideally on a
per-dataset basis.  I haven't decided how to implement this.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    a91d1e5 View commit details
    Browse the repository at this point in the history

  5. Add braces for readability 

    Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    2375d34 View commit details
    Browse the repository at this point in the history

  6. Default to xattr_compat=linux on Linux 

    This avoids activating feature@xattr_compat by default in TrueNAS while
the feature is still waiting to be upstreamed.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    1b34777 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Add xattr_fallback property to skip fallbacks 

    This property defaults to "on" so by default we do not miss xattrs in
datasets received from pools for which the encoding cannot be known or
may even be a mix of both.  It can be turned "off" for a performance
boost when it is known only the configured xattr_compat format is
relevant.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    133096f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Update ABI after adding xattr_fallback 

    Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    c9e32ea View commit details
    Browse the repository at this point in the history

  2. Fix mancheck 

    Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
    Ryan Moeller authored and Ryan Moeller committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    40b0ef2 View commit details
    Browse the repository at this point in the history