Remove feature@xattr_compat and xattr_fallback #24
Conversation
ghost
requested a review
from 
|
Maybe I should remove the xattr_fallback property while I'm at it. |
|
Fully removing the feature flag from ZFS feels like the better long term solution to me, but it may be painful for a handful of beta users. |
|
Just sorting out the DEB build failure... |
| flags &= ~XATTR_REPLACE; | ||
| error = zpl_xattr_set(ip, name, value, size, flags); | ||
|
|
||
| dsl_dataset_t *ds = dmu_objset_ds(ITOZSB(ip)->z_os); | ||
| ds->ds_feature_activation[SPA_FEATURE_XATTR_COMPAT] = (void *)B_TRUE; | ||
|
|
There was a problem hiding this comment.
I am thinking, who of users could already have this feature activated (like that one who had complained)? Only those who hit the original version of the patch before we made Scale default to Linux format? We should figure out what to write on release notes.
There was a problem hiding this comment.
Users would have had to upgrade their existing pool from CORE in SCALE or created a new pool in SCALE to enable the feature, but then the default is xattr_compat=linux, so they would have had to change that property manually as well as far as I'm aware. I don't see anything in middleware that changes xattr_compat from the default for you.
xattr_compat was merged in #8 on June 29 and the default was changed to xattr_compat=linux in #16 on July 15, so only nightly users who created or upgraded a pool using a build from those two weeks would have xattr_compat=all on Linux unwittingly.
For now we'll keep the feature available, but never activate it. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
changed the title
|
The CI failures seem to be on Github's end, perhaps we were on a particularly busy host yesterday. I ran the test suite locally and built a deb successfully as well yesterday. I'm building and running sanity tests again for this latest push right now just in case the CI is still acting up. |
|
Tests pass locally, I'll work out the CI issues separately. |
A quick bandage so we don't activate this feature going forward, since it won't be in the upstreamed version.
I've kept knowledge of the feature in for now so upgraders won't lose access to their pools, but removed the activation so the feature can be disabled in the future as long as it's not already active.
Jira: NAS-112725