Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ahrav committed Oct 22, 2024
1 parent 043ed06 commit b2ca7d7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/sources/s3/s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ func (s *Source) pageChunker(
ctx.Logger().V(2).Info("Skipped due to excessive errors")
return nil
}

// Make sure we use a separate context for the GetObjectWithContext call.
// This ensures that the timeout is isolated and does not affect any downstream operations. (e.g. HandleFile)
const getObjectTimeout = 30 * time.Second
objCtx, cancel := context.WithTimeout(ctx, getObjectTimeout)
defer cancel()
Expand Down

0 comments on commit b2ca7d7

Please sign in to comment.