Error: unable to parse link to update line number

[rgmz]

Please review the Community Note before submitting

TruffleHog Version

3.61.0

Description

Scanning a file with the path meta-xilinx/meta-xilinx-contrib/recipes-kernel/linux-firmware/linux-firmware_%.bbappend (escaped as %25 in the url) produces the following error:

2023-10-30T09:13:31-04:00       error   trufflehog      unable to parse link to update line number
{
  "detector_worker_id": "e4wt4",
  "timeout": 10,
  "link": "https://github.com/ibm-openbmc/openbmc/blob/286d45cc649a5b852a27b48e61b51bf75e9d1cee/meta-xilinx/meta-xilinx-contrib/recipes-kernel/linux-firmware/linux-firmware_%.bbappend#L1",
  "error": "parse \"https://github.com/ibm-openbmc/openbmc/blob/286d45cc649a5b852a27b48e61b51bf75e9d1cee/meta-xilinx/meta-xilinx-contrib/recipes-kernel/linux-firmware/linux-firmware_%.bbappend\": invalid URL escape \"%.b\""
}

I'm not sure if there's anything that can be done to combat this. The error seems to be coming from url.Parse.

trufflehog/pkg/giturl/giturl.go

Lines 155 to 159 in 2a66d41

	parsedURL, err := url.Parse(link)
	if err != nil {
	ctx.Logger().Error(err, "unable to parse link to update line number", "link", link)
	return link
	}

[rgmz]

This issue should be easily solved by replacing % with %25 prior to calling url.Parse.

https://en.wikipedia.org/wiki/Percent-encoding

[rgmz]

Fixed by #2214.