Encode '%' when generating Git URLs #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rgmz
force-pushed
the
fix/git-link-parse
branch
from
6a3f7c7 to
7e10a99
Compare
|
Nice! I think this solution can be improved to cover all escapes via url.PathEscape. |
That's a good point. I wasn't sure if additional escapes would break anything as I only encountered the issue with |
haraldh
referenced
this pull request
in matter-labs/vault-auth-tee
Dec 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog) | action | patch | `v3.63.3` -> `v3.63.4` | --- ### Release Notes <details> <summary>trufflesecurity/trufflehog (trufflesecurity/trufflehog)</summary> ### [`v3.63.4`](https://github.com/trufflesecurity/trufflehog/releases/tag/v3.63.4) [Compare Source](https://github.com/trufflesecurity/trufflehog/compare/v3.63.3...v3.63.4) #### What's Changed - Bump github.com/docker/docker from 24.0.0+incompatible to 24.0.7+incompatible by [@​dependabot](https://github.com/dependabot) in [https://github.com/trufflesecurity/trufflehog/pull/2213](https://github.com/trufflesecurity/trufflehog/pull/2213) - Fix emoji in README by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2217](https://github.com/trufflesecurity/trufflehog/pull/2217) - Upgrade sevenzip to v1.4.5 by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2215](https://github.com/trufflesecurity/trufflehog/pull/2215) - Encode '%' when generating Git URLs by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2214](https://github.com/trufflesecurity/trufflehog/pull/2214) - Fix GitParse trimming whitespace from filename by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2201](https://github.com/trufflesecurity/trufflehog/pull/2201) - \[fixup] - Avoid reading decompressed data into memory by [@​ahrav](https://github.com/ahrav) in [https://github.com/trufflesecurity/trufflehog/pull/2196](https://github.com/trufflesecurity/trufflehog/pull/2196) - Update GitLab v1 verification to check for valid JSON response by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2218](https://github.com/trufflesecurity/trufflehog/pull/2218) - Check for SourceUnit support dynamically in the SourceManager by [@​mcastorina](https://github.com/mcastorina) in [https://github.com/trufflesecurity/trufflehog/pull/2205](https://github.com/trufflesecurity/trufflehog/pull/2205) - Fix GitHub source showing 0 members by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2202](https://github.com/trufflesecurity/trufflehog/pull/2202) - Don't run 'test' workflow in forks by [@​rgmz](https://github.com/rgmz) in [https://github.com/trufflesecurity/trufflehog/pull/2221](https://github.com/trufflesecurity/trufflehog/pull/2221) **Full Changelog**: trufflesecurity/trufflehog@v3.63.3...v3.63.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/vault-auth-tee). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This fixes an issue where file paths that contain
%would causeUpdateLinkLineNumberto break.Example:
Checklist:
make test-community)?make lintthis requires golangci-lint)?