Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating sendbird detector to use tri-state verification #1737

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

0x1
Copy link
Contributor

@0x1 0x1 commented Aug 31, 2023

Description:

updating Sendbird detector to use tri-state verification

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice digging! i have two nits and one question about intentional functionality.

pkg/detectors/sendbird/sendbird_test.go Outdated Show resolved Hide resolved
pkg/detectors/sendbird/sendbird_test.go Show resolved Hide resolved
pkg/detectors/sendbird/sendbird.go Outdated Show resolved Hide resolved
@0x1 0x1 requested a review from rosecodym September 1, 2023 19:34
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the tests

@0x1 0x1 merged commit b28a2b9 into main Sep 5, 2023
@0x1 0x1 deleted the sendbird-tri-state branch September 5, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants