Updated Fastly Personal Token Detector #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
changed the title
abmussani
reviewed
Oct 9, 2024
Comment on lines
+35
to
+37
| TokenID string `json:"id"` | ||
| UserID string `json:"user_id"` | ||
| ExpiresAt string `json:"expires_at"` |
There was a problem hiding this comment.
@kashifkhan0771 Response also contains scope of that token. My suggestion would be to include it in the extraData.
abmussani
reviewed
Oct 9, 2024
| continue | ||
| extraData, verified, verificationErr := verifyFastlyApiToken(ctx, resMatch) | ||
| s1.Verified = verified | ||
| if extraData != nil { |
There was a problem hiding this comment.
Nit: IMO nil check for extraData is unneccesary.
| } | ||
| got[i].Raw = nil | ||
| } | ||
| if diff := pretty.Compare(got, tt.want); diff != "" { |
There was a problem hiding this comment.
I have doubt that this test will fail due to extraData diff (nil vs Map) in valid & verified cases.
There was a problem hiding this comment.
Yeah, good catch! I'll update these test cases.
rgmz
reviewed
Oct 9, 2024
| extraData, verified, verificationErr := verifyFastlyApiToken(ctx, match) | ||
| s1.Verified = verified | ||
| s1.ExtraData = extraData | ||
| s1.SetVerificationError(verificationErr) |
There was a problem hiding this comment.
I think we're supposed to pass the secret(s) as varargs to SetVerificationErr so they get redacted? Been a while and I'm on my phone so Idk.
I think @ahrav would know.
There was a problem hiding this comment.
Yeah, it does take secrets as a optional second parameter.
abmussani
added a commit
to abmussani/trufflehog
that referenced
this pull request
Oct 14, 2024
* main: (127 commits) Update SaladCloud description (trufflesecurity#3399) fix tests (trufflesecurity#3400) [chore] Update custom detector default description (trufflesecurity#3398) add description to salad (trufflesecurity#3397) Add detector for SaladCloud API Keys (trufflesecurity#3273) fix(deps): update module github.com/xanzy/go-gitlab to v0.111.0 (trufflesecurity#3393) Add SliceContainsString common util (trufflesecurity#3395) fix: pr template link to golangci-lint (trufflesecurity#3392) fix(deps): update golang.org/x/exp digest to f66d83c (trufflesecurity#3389) Separate detector tests into unit/integration (trufflesecurity#3274) Manually upgrade github dep (trufflesecurity#3387) Updated Fastly Personal Token Detector (trufflesecurity#3386) fix(deps): update module google.golang.org/api to v0.200.0 (trufflesecurity#3391) [Fix] Snowflake privatelink Support (trufflesecurity#3286) Enhanced the easyinsight detector (trufflesecurity#3384) Log skipped files on debug level (trufflesecurity#3383) build: update retracted bluemonday ver (trufflesecurity#3369) Fix git binary handling and add a smoke test (trufflesecurity#3379) fix(deps): update module google.golang.org/protobuf to v1.35.1 (trufflesecurity#3382) Added Cisco Meraki API Key detector (trufflesecurity#3367) ... # Conflicts: # pkg/engine/defaults.go # pkg/pb/detectorspb/detectors.pb.go # proto/detectors.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
/tokens/self.Output format for valid Token:
Pattern Test Cases:
Checklist:
make test-community)?make lintthis requires golangci-lint)?