Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overseer warn, and don't os.Exit on git error. #348

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Remove overseer warn, and don't os.Exit on git error. #348

merged 1 commit into from
Apr 9, 2022

Conversation

bill-rich
Copy link
Collaborator

No description provided.

dustin-decker
dustin-decker reviewed Apr 9, 2022
View reviewed changes
pkg/sources/git/git.go
}

// Errors returned on errChan aren't blocking, so just ignore them.
errChan := make(chan error)
Copy link
Contributor

@dustin-decker dustin-decker Apr 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do any logging with these?

@dustin-decker dustin-decker merged commit 6be5ee1 into main Apr 9, 2022
@dustin-decker dustin-decker deleted the avoid_child_exit_errors branch April 9, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bill-rich @dustin-decker