Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log why false positives are skipped #3579

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Log why false positives are skipped #3579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/detectors/falsepositives.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ func FilterKnownFalsePositives(ctx context.Context, detector Detector, results [

for _, result := range results {
if len(result.Raw) == 0 {
ctx.Logger().Error(fmt.Errorf("empty raw"), "invalid result; skipping")
ctx.Logger().Error(fmt.Errorf("empty raw"), "Skipping result: invalid")
continue
}

Expand All @@ -190,9 +190,11 @@ func FilterKnownFalsePositives(ctx context.Context, detector Detector, results [
continue
}

if isFp, _ := isFalsePositive(result); !isFp {
filteredResults = append(filteredResults, result)
if isFp, reason := isFalsePositive(result); isFp {
ctx.Logger().V(4).Info("Skipping result: false positive", "result", result.Raw, "reason", reason)
continue
}
filteredResults = append(filteredResults, result)
}

return filteredResults
Expand Down
Loading