Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to new endpoint for IBM Cloud #397

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Updated to new endpoint for IBM Cloud #397

merged 2 commits into from
Apr 15, 2022

Conversation

jjasghar
Copy link
Contributor

Taken from https://cloud.ibm.com/apidocs/codeengine#get-kubeconfig
The IAM is now pointing to long term one, and also updated the
additional information in the POST

Taken from https://cloud.ibm.com/apidocs/codeengine#get-kubeconfig
The IAM is now pointing to long term one, and also updated the
additional information in the POST
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2022

CLA assistant check
All committers have signed the CLA.

@dustin-decker
Copy link
Contributor

Thank you for the contribution. Can you sign the CLA?

I tested this change and the test passes with the endpoint change but not with the payload change.

@dustin-decker dustin-decker self-requested a review April 14, 2022 16:15
@dustin-decker dustin-decker self-assigned this Apr 14, 2022
@jjasghar
Copy link
Contributor Author

Ah interesting, the update had &refresh_token=${refreshToken} as an option, i wasn't 100% sure how to add that. maybe just the updated URL is what we need?

Rollback to the original options.
@dustin-decker dustin-decker merged commit 4954086 into trufflesecurity:main Apr 15, 2022
bill-rich pushed a commit that referenced this pull request May 2, 2022
* Updated to new endpoint for IBM Cloud

Taken from https://cloud.ibm.com/apidocs/codeengine#get-kubeconfig
The IAM is now pointing to long term one, and also updated the
additional information in the POST

* Update ibmclouduserkey.go

Rollback to the original options.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants