Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add eth_signTypedData #149

Merged
merged 3 commits into from
Aug 15, 2018
Merged

Add eth_signTypedData #149

merged 3 commits into from
Aug 15, 2018

Conversation

rmeissner
Copy link
Contributor

Adds support for eth_signTypedData according to EIP-712

This is required for #515

@rmeissner
Copy link
Contributor Author

How should conflicts in npm-shrinkwrap be resolved?

@benjamincburns
Copy link
Contributor

Hi @rmeissner! Thanks for the contribution.

I think shrinkwrap conflicts should be handled by making sure that existing versions don't change.

Otherwise I'm a little hesitant about this change, primarily because EIP-712 is still listed as draft status, and I can't find where either geth or Parity support it yet. I see that MetaMask has added support, however - so maybe that's good enough since most web apps will be interacting with the client via them or some other wallet middleware...

@benjamincburns
Copy link
Contributor

As I said on the issue, I'm walking back that comment a bit - I really like the interaction this helps to support and I'd rather help move things forward by adding preliminary support for the RPC call. I'll merge this.

@benjamincburns benjamincburns merged commit e300dae into trufflesuite:develop Aug 15, 2018
@rmeissner rmeissner deleted the add_eth_signTypedData branch November 9, 2018 22:10
@benjamincburns benjamincburns removed their assignment Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants