Feature/eslint prettier

[honestbonsai]

Resolves #1080

[adrianmcli]

noice, lgtm

[adrianmcli]

@honestbonsai not sure why the PR build failed. Looks like an issue with the windows build? I'm inclined to just merge it anyway since the branch build was fine, but I'm not sure.

[mikeseese]

I believe that appveyor has issues signing on the pr build. You need to investigate what the error is before "inclining to merge". The error was related to signing, and the other appveyor build was successful, which I would consider sufficient

[adrianmcli]

You need to investigate what the error is before "inclining to merge".

@seesemichaelj thanks for taking a look. I did investigate as I mentioned, but I couldn't make sense of all the windows noise.

Error: Cannot extract publisher name from code signing certificate

I don't know how windows builds work, but if the branch build was ok I don't see how this shouldn't be either. Why is this not deterministic?

[mikeseese]

thanks for taking a look. I did investigate as I mentioned, but I couldn't make sense of all the windows noise.

@adrianmcli haha, I usually just read the first red line

I don't know how windows builds work, but if the branch build was ok I don't see how this shouldn't be either. Why is this not deterministic?

I'm not sure actually. I didn't setup the build processes and didn't take the time to figure it out. I'm guessing some signing env variable is not set properly. If you look at the history of appveyor.yml there was a commit about getting PR builds to get fixed from @benjamincburns. Perhaps the solution was there and got removed/changed over the last few months 🤷‍♂️

[adrianmcli]

We really need a dedicated electron guy on this.

[honestbonsai]

Thanks! Good to know about the keys and signing breaking PR builds.