Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

All transaction signatures whose s-value is greater than secp256k1n/2 are now considered invalid, but ganache accepts them #2600

Closed
davidmurdoch opened this issue Mar 14, 2022 · 0 comments · Fixed by #2944
Closed

All transaction signatures whose s-value is greater than secp256k1n/2 are now considered invalid, but ganache accepts them #2600

davidmurdoch opened this issue Mar 14, 2022 · 0 comments · Fixed by #2944

Comments

@davidmurdoch
Copy link
Member

According to EIP-2 "All transaction signatures whose s-value is greater than secp256k1n/2 are now considered invalid."
the signature generated by hardware wallet has s component greater than secp256k1n/2 .

Ganache currently permits this greater "s" value.
davidmurdoch added a commit that referenced this issue Mar 14, 2022
@davidmurdoch
also fix #2600
4856af1
@davidmurdoch davidmurdoch mentioned this issue Mar 14, 2022
Closed
@davidmurdoch davidmurdoch mentioned this issue Apr 20, 2022
Merged
@X-oss-byte X-oss-byte mentioned this issue Aug 12, 2023
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 23, 2023
Open
This was referenced Nov 23, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 2, 2023
Open
Open
Open
Open
Open
Open
This was referenced Dec 14, 2023
Open
Open
Open
@X-oss-byte X-oss-byte mentioned this issue Dec 31, 2023
Open
This was referenced Feb 23, 2024
Open
Open
Open
This was referenced Mar 5, 2024
Open
Open
Open
This was referenced Mar 12, 2024
Open
Open
Open
Open
This was referenced Mar 20, 2024
Open
Open
This was referenced Mar 27, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 16, 2024
Open
Open
This was referenced Apr 17, 2024
Open
Open
@CASABECI CASABECI mentioned this issue Oct 11, 2024
Open
This was referenced Oct 11, 2024
Open
Open
Open
@CASABECI CASABECI mentioned this issue Oct 18, 2024
Open
This was referenced Oct 18, 2024
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enforce eip-2 imposed limits and secp256k1 upper bound for private keys trufflesuite/ganache
1 participant
@davidmurdoch