Forking mainnet results in erroneous revert on ganache-cli 6.12.0+

[mrice32]

Opening a new issue because #571 is closed.

We've had a very similar re-entrancy guard issue with ganache forking. This update fixed our issue in ganache-cli release 6.10.2. But after trying different versions, we noticed a regression in ganache-cli versions 6.12.0+.

You can repro the issue in this repo: https://github.com/UMAprotocol/launch-emp. We have a two simple scripts -- one runs a ganache fork and the other runs a node script against that fork.

There are two branches, the only difference between the two being the ganache version.

Working branch: https://github.com/UMAprotocol/launch-emp/tree/ganache_working.
Broken branch: https://github.com/UMAprotocol/launch-emp/tree/ganache_broken.

After checking out each branch run the following in separate shells.

Shell 1:

yarn
# Thin yarn script to run ganache-cli
yarn ganache-fork

Shell 2:

node index.js --gasprice 100

[0xTimepunk]

I am having this issue too with the latest ganache version. Comented here as well because the other issue is closed.

@davidmurdoch

compound-finance#5

[mikeseese]

While I'm no longer with the Truffle team, @davidmurdoch would likely ask for the same thing; @0xTimepunk, could you provide reproduction steps? The error y'all are seeing is a generic symptom caused by several different issues, so it's possible that a fix for @mrice32 would not be a fix for you @0xTimepunk. Reproduction steps can help whoever ends up looking into this more

[mzatroch]

The same issue calling liquidateBorrow(address,CToken) from cEther compound contract -> revert re-entered error returned

[mikeseese]

Hey @mzatroch, please open a new issue. It helps if you provide detailed reproduction steps since the error is a common symptom for several different causes. Thanks!

[ajb413]

Can't seem to run Compound cToken exchangeRateCurrent (this) without hitting revert re-entered when forking mainnet. Using Node.js 12.14.1. MacBook Pro (15-inch, 2019) on macOS Big Sur 11.3. Made an example here https://github.com/ajb413/ganache-bug-example. Instructions for running it are in the readme.

edit: I was able to resolve my fork issues by switching to hardhat