build(ganache-cli): bump version to v6.12.0 to fix node 14 errors #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 6.12.0 includes fixes for Node 14 Signed-off-by: Ashutosh Varma <ashutoshvarma11@live.com>
fulminmaxi
requested review from
a team,
daywiss,
smb2796,
mrice32 and
pemulis
and removed request for
a team,
smb2796 and
daywiss
daywiss
approved these changes
May 4, 2021
|
@ashutoshvarma The reason we can't upgrade to a node 14 compatible version is trufflesuite/ganache#797. Please let us know if you are able to actually deploy an EMP on a fork with your PR. Last time I tried with 6.12.0+, I got a false re-entrancy error. |
|
@ashutoshvarma @mrice32 I'm going to close this one for now! We can re-open if there is a later upgrade to Ganache that solves the node v14 error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 6.12.0 includes fixes for Node 14 - trufflesuite/ganache#732 (comment)
In node 14, while trying to test deployment script on fork using
yarn ganache-fork wss://kovan.infura.io/ws/v3/<PROJECT_ID>kept getting
Error: Callback was already called.