This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
External library function calls #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uite/ganache-core into external-library-function-calls
davidmurdoch
force-pushed
the
external-library-function-calls
branch
from
74d8e76
to
8a030f4
Compare
This was referenced Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test addresses
ganache-cliissue #399. After looking into the issue, themsg.senderfor external library function calls should actually be the externally owned account. Deployed bothLibrary.solandCallLibrary.solon the Ropsten testnet and verified this is the expected behavior.