This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Incorrect tx receipt trie root #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
suggested changes
Feb 19, 2019
There was a problem hiding this comment.
I'd prefer not to see test refactor changes in these commits (I know we've done these drive-by refactorings in the past) since chris is currently refactoring everything to async/await right now. There may end up being merge conflicts with #313.
Agreed, just for background this test was updated before any refactoring started. I did make sure to notify and remind chris of the changes to hopefully avoid any conflicts. |
davidmurdoch
approved these changes
Feb 20, 2019
This was referenced Feb 28, 2019
This was referenced Mar 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither the
transactionsTrienor thereceiptsTriewere being calculated and the resultingtransactionsRootandreceiptsRootwere always identical (EMPTY_TRIE_ROOT) when there were 1 or more transactions in a block.This PR suggests a fix by:
Creating 2 empty Tries and populating them with tx index (within the block) as the keys and transactions/receipts for their respective values. The resulting Trie's roots are then copied to
block.header.transactionsTrieandblock.header.receiptTrierespectively.