This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
docs: restyle docs to be more "Truffley" #4035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Murdoch <david@davidmurdoch.com>
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
OnlyOneJMJQ
requested review from
MicaiahReid and
davidmurdoch
as code owners
OnlyOneJMJQ
changed the title
jeffsmale90
changed the title
|
This looks great! |
jeffsmale90
reviewed
Dec 15, 2022
| @@ -44,7 +44,7 @@ | |||
| font-family: "Open sans"; | |||
| transform: translate(-3vw, calc(-100% + 3.05vw)); | |||
| padding: 0.5vw 1vw 3vw; | |||
| text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.5); | |||
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.5); */ | |||
There was a problem hiding this comment.
we should probs delete this I guess?
Suggested change
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.5); */ |
There was a problem hiding this comment.
Totally. I just commented this out initially because I was unsure if it aided readability in dark mode (I was primarily working in light mode at the time).
| @@ -65,7 +65,7 @@ | |||
| *:not(pre) > code, | |||
| .hljs { | |||
| font-family: "Share Tech Mono", monospace; | |||
| text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.7); | |||
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.7); */ | |||
There was a problem hiding this comment.
Suggested change
| /* text-shadow: 0 -1px 1px rgba(0, 0, 0, 0.7); */ |
davidmurdoch
changed the title
|
UPDATE: They were caused by the padding. Outstanding issues:
I think these are both caused by the padding I added to |
MicaiahReid
force-pushed
the
docs-perf
branch
from
764a928
to
cf8fe21
Compare
|
Closing because #4033 implements most of this now. Thanks, @OnlyOneJMJQ! I'll be sure to add you as a co-author on the eventual merge of #4033. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought the styling of the docs closer to Truffle Dashboard, including fun things like a color changing theme switcher icon! Contrast is greater in the console elements in light mode as well. Other minor changes too numerous to list.