This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
test: ensure tests that are skipped in development are run in CI #4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'listens on given interface only' test which was incorrectly skipped in CI.
jeffsmale90
commented
Apr 13, 2023
Deploying with
|
| Latest commit: |
dcb8bde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9eecb02b.ganache.pages.dev |
| Branch Preview URL: | https://test-improve-infura-integrat.ganache.pages.dev |
jeffsmale90
commented
Apr 13, 2023
jeffsmale90
changed the title
…ments for 'listen' test.
jeffsmale90
commented
Apr 16, 2023
jeffsmale90
commented
Apr 16, 2023
src/chains/ethereum/ethereum/tests/helpers/skipIfNoInfuraKey.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
davidmurdoch
approved these changes
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tests that depend on an INFURA_KEY would be skipped if it were not provided. After this change these tests will fail in CI if no INFURA_KEY is provided.
Additionally, a test which was previously skipped is now run on Windows and Linux agents in Github Actions only. (
> server > listens on given interface only)