This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: use localhost as hostname for docs.preview dev command
#4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
reviewed
Apr 16, 2023
| @@ -27,7 +27,7 @@ | |||
| "scripts": { | |||
| "docs.build": "npx shx rm -rf ./lib/docs ./lib/api.json && npm run docs.typedoc", | |||
| "docs.typedoc": "typedoc --options ./typedoc.json --readme ./README.md --out ../../../../docs/typedoc --json ../../../../docs/typedoc/api.json src/api.ts", | |||
| "docs.preview": "ws --open --port 3010 --directory ../../../../docs", | |||
| "docs.preview": "ws --open --hostname localhost --port 3010 --directory ../../../../docs", | |||
There was a problem hiding this comment.
Fair enough - I don't use WSL, but trust that this does help :)
There was a problem hiding this comment.
Haha. 127.0.0 doesn't make it to wsl from windows by default, but localhost does.
jeffsmale90
approved these changes
Apr 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just to make ganache development from WSL easier.