This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 680
refactor: rewrite into a TypeScript monorepo, partial #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript * ganache: ^4.1.0-beta → 4.1.0-beta
. . .
davidmurdoch
added a commit
that referenced
this pull request
Nov 16, 2020
davidmurdoch
added a commit
that referenced
this pull request
Nov 16, 2020
davidmurdoch
added a commit
that referenced
this pull request
Nov 16, 2020
davidmurdoch
added a commit
that referenced
this pull request
Nov 18, 2020
davidmurdoch
added a commit
that referenced
this pull request
Jan 12, 2021
davidmurdoch
added a commit
that referenced
this pull request
Jan 19, 2021
sambacha
pushed a commit
to contractshark/ganache-core
that referenced
this pull request
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR omits the Ethereum forking feature,
debug_traceTransaction
, and Tezos support.This PR is a breaking change.
KNOWN ISSUES:
While pending transaction support now works, the "pending" block tag doesn't work yet.
FEATURES:
provider
now works in the browserlegacyInstamine
modecoinbase
option (fixes block.coinbase does only return 0x #201)chainId
optionwsBinary
(true
,false
"auto", defaults to "auto")number
is supportedevm_increaseTime
now takes either a number or a JSON-RPC hex-encoded QUANTITY value (closes evm_increaseTime does not follow ETH-RPC conventions #118)evm_setAccountNonce
closes Feature request: allow incrementing nonce of unlocked accounts #589getOptions()
to provider instancegetInitialAccounts()
to provider instanceonce
event emitter method (e.g.,await provider.once("message")
)send
overload:send(method: string, params: unknown[]): Promise<unknown>
FIXES:
eth_getBlock*
callseth_sign
returns correct signatures fixes eth_sign should return chainId-relative signature with high-level v values #556BREAKING CHANGE:
Runtime Error:
errors are now "Runtime error:`provider
andserver
internals are no longer exposed via its properties.web3_clientVersion
now returnsGanache/v{number/number/number}
signer account is locked
error toauthentication needed: password or unlock
Exceeds block gas limit
error toexceeds block gas limit
vmErrorsOnRPCResponse
option defaults tofalse
chainId
option defaults to1337
server.listen
isn't pre-bound to theserver
instance (server.listen.bind(server)
)provider.send
isn't pre-bound to theprovider
instance (provider.listen.bind(provider)
)remveAllListeners
to provider.clearListenersoptions.keepAliveTimeout
provider.close
is nowprovider.disconnect
and returns promise (no callback argument)Cannot wrap a "[a-zA-Z]+" as a json-rpc type
onevm_revert
error instead ofinvalid type
orfalse
for invalid snapshot idsdata
to be valid json-rpc hex-encoded DATA (must start with0x
)gas
/gasLimit
v
values are no longer allowedinvalid block number
error tocannot convert string value "" into type
Quantity; strings must be hex-encoded and prefixed with "0x".
Method {method} not supported
error toThe method {method} does not exist/is not available
provider.connection.close
is no longer a thing on the web3 provider (NEEDS MORE INFO!)wsBinary
value
string to be valid JSON-RPC encoded QUANTITY ("1000" is no longer valid!)provider.options
withprovider.getOptions()
error
andresult
via the provider when using old provider.send viacallback
.legacyInstamine
mode only): error messages are returned on the result'sdata
field now. Previously they were contained within a combination of the 'results: {[hash: string]: unknown}' and 'hashes: string[]' properties. Also, onlyevm_mine
andminer_start
return an array for the 'data' field, as these are the only places where multiple transactions may be executed (this isn't entirely true when a nonce is skipped and then the skipped nonce is executed, but this behavior wasn't supported in v2 anyway!).coinbase
(eth_coinbase
RPC call) is now the0x0
address (fixes block.coinbase does only return 0x #201)gasPrice
options
now always treat strings that represent numbers as hex strings, not numbersgasLimit
is now 12Msender doesn't have enough funds to send tx
errors are now prefixed withVM Exception while processing transaction
'`logs
subscription events are emitted beforenewHeads
events