Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Suppress web3 MaxListenersExceededWarning #1088

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Conversation

cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Jul 5, 2018

  • Underlying issue described at web3 is here.
  • Rejected PR at web3 to end-run warning.

Suggests this isn't obviously the result of negligence cleaning up emitters here. Also not proof of a lack of negligence, although have tried hard not to neglect this.

Also looks like it's not possible to manually set these limits on the PromiEvent since that part of the EventEmitter interface isn't exposed.

Warning looks like this:

(node:60858) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 data listeners added. Use emitter.setMaxListeners() to increase limit

Believe this will also need to be done for the console/develop but a different approach might be possible there. Mocha implements it's --no-warnings option by passing it as node flag to the process when they shell out.

@cgewecke cgewecke requested a review from gnidan July 5, 2018 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants