This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Dependency update: Upgrade web3 packages to 1.2.0 #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* truffle: 1.0.0-beta.37 → 1.2.0 * truffle-artifactor: 1.0.0-beta.37 → 1.2.0 * truffle-contract: 1.0.0-beta.37 → 1.2.0 * truffle-core: 1.0.0-beta.37 → 1.2.0 * truffle-debugger: 1.0.0-beta.37 → 1.2.0 * truffle-decode-utils: 1.0.0-beta.37 → 1.2.0 * truffle-decoder: 1.0.0-beta.37 → 1.2.0 * truffle-deployer: 1.0.0-beta.37 → 1.2.0 * truffle-environment: 1.0.0-beta.37 → 1.2.0 * truffle-hdwallet-provider: 1.0.0-beta.37 → 1.2.0 * truffle-interface-adapter: 1.0.0-beta.37 → 1.2.0 * truffle-migrate: 1.0.0-beta.37 → 1.2.0 * truffle-provider: 1.0.0-beta.37 → 1.2.0 * truffle-require: 1.0.0-beta.37 → 1.2.0
* truffle-contract: 1.0.0-beta.37 → 1.2.0
|
Shouldn't Web3 packages be required with |
…et-provider as it is in dependencies
eggplantzzz
force-pushed
the
upgrade-web3-version1
branch
from
f4ab037
to
b8e8aff
Compare
|
Yep, lerna-update-wizard did not add the |
eggplantzzz
changed the title
CruzMolina
approved these changes
Jul 23, 2019
|
I see some changes to truffle-decoder, but you just mentioned in standups that you weren't changing that package. Just wanted to check in on that! Otherwise this looks fine to me. |
|
What I was mentioning was that I was not editing the version of |
|
Party time! |
|
@eggplantzzz This fixes #2140 so please close it. |
|
@filips123 we typically seek to close issues upon release, not merge :) |
|
also: hooray! |
|
@gnidan I didn't know. When it will be released? |
Tomorrow @filips123 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade web3 packages to 1.2.0.
Non-exhaustive (possibly) list of packages effected by web3 upgrade: