Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Remove devtool from production bundle #268

Merged
merged 10 commits into from
Dec 1, 2022
Merged

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Nov 25, 2022

PR description

This PR is a follow-up of #245. The main goal is to improve performance, more specifically, when activating the extension by reducing package size. See #245 (comment) for more details.

Moreover, it builds the vsix package in CI as a smoke check.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

@acuarica acuarica mentioned this pull request Nov 25, 2022
1 task
Copy link
Contributor

@michaeljohnbennett michaeljohnbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@acuarica acuarica marked this pull request as ready for review November 30, 2022 13:36
@acuarica acuarica requested review from kevinbluer and xhulz November 30, 2022 13:36
Copy link
Member

@kevinbluer kevinbluer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick smoke test and all good (although it's more likely any issues would come up post-bundling anyhow). Just worth us making sure we do the same when it hits pre-release on the marketplace.

Copy link
Member

@kevinbluer kevinbluer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was submitting from the GH extension in VS Code and mistakenly just commented rather than approving (again) 🤦‍♂️

@acuarica acuarica merged commit 927c170 into develop Dec 1, 2022
@acuarica acuarica deleted the fix/remove-prod-devtool branch December 1, 2022 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants