Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated libs should have a .babelrc #37

Closed
trumbitta opened this issue Jul 29, 2021 · 0 comments · Fixed by #38
Closed

Generated libs should have a .babelrc #37

trumbitta opened this issue Jul 29, 2021 · 0 comments · Fixed by #38
Assignees
@trumbitta
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@trumbitta
Copy link
Owner

trumbitta commented Jul 29, 2021 •
edited
Loading

Like this one:

{
  "presets": [["@nrwl/web/babel", { "useBuiltIns": "usage" }]]
}

tsconfg files would be nice too, I guess.

Didn't catch this earlier because in my own monorepo at work, a migration added the file for me.

It should be fairly easy to look into the code of some official plugins and figure out how they do it.

To avoid regressions, I'm thinking it's also time to add a new e2e test to the executor: once sources get generated (current test), also import something from the lib into an app and build the app to see if there's any problem preventing it to compile, like the missing .babelrc.
@trumbitta trumbitta added bug Something isn't working good first issue Good for newcomers labels Jul 29, 2021
@trumbitta trumbitta changed the title generated libs should have a .babelrc Generated libs should have a .babelrc Jul 29, 2021
trumbitta added a commit that referenced this issue Jul 29, 2021
@trumbitta
feat(nx-plugin-openapi): update to Nx v12.6.2 and revert unwanted @an…
e028dc3 
…gular devkit dep

re #37
@trumbitta trumbitta self-assigned this Jul 29, 2021
@trumbitta trumbitta mentioned this issue Jul 29, 2021
Merged
4 tasks
trumbitta added a commit that referenced this issue Jul 30, 2021
@trumbitta
feat(nx-plugin-openapi): add .babelrc to generated api libs
c002a7c 
fix #37
trumbitta added a commit that referenced this issue Jul 30, 2021
@trumbitta
test(nx-plugin-openapi-e2e): cut the execution time by ~half
82d09cd 
re #37
trumbitta added a commit that referenced this issue Jul 30, 2021
@trumbitta
docs(readme): remove @angular-devkit/schematics as peer dependency 🤞
b8ebb44 
re #37
github-actions bot pushed a commit that referenced this issue Jul 30, 2021
@semantic-release-bot
chore(release): 1.6.0
91252f3 
## [1.6.0](v1.5.1...v1.6.0) (2021-07-30)

### Features

* **nx-plugin-openapi:** add .babelrc to generated api libs ([c002a7c](c002a7c)), closes [#37](#37)
* **nx-plugin-openapi:** update to Nx v12.6.2 and revert unwanted [@angular](https://github.com/angular) devkit dep ([e028dc3](e028dc3)), closes [#37](#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trumbitta trumbitta

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add .babelrc to libs trumbitta/nx-trumbitta
1 participant
@trumbitta