Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydot again instead of pydotplus #111

Closed
petrrr opened this issue Jun 30, 2017 · 4 comments
Closed

Use pydot again instead of pydotplus #111

petrrr opened this issue Jun 30, 2017 · 4 comments

Comments

@petrrr
Copy link

petrrr commented Jun 30, 2017

According to the HISTORY the switch from pydot to pydotplus was done approx. 2 year ago. I assume this was done for a lack of activity and missing Python 3 support. Some time back the development of pydot was stale and it was not clear which of the many forks to use.

Now the situation with pydot seems to have recovered and developments seems to take place and converging at https://github.com/erocarrera/pydot. pydot now claims to support python 3. See also https://pypi.python.org/pypi/pydot/1.2.3

Wouldn't it make sense to switch back to pydot again?

@trungdong
Copy link
Owner

Many thanks @petrrr for checking this. I looked at pydot build and see that it is now tested against Python 3 (https://travis-ci.org/erocarrera/pydot).

You're right that we switched to pydotplus because it supports Python 3. Having said that, I'm not sure whether both libraries are drop-in equivalent or not.

Is there any compelling reason to go for pydot?

@petrrr
Copy link
Author

petrrr commented Jun 30, 2017

@trungdong: I intend to packages prov in Macports, a package manager for the OSX.

The point here is that dealing with multiple fork of the same/equivalent packages gets quite tricky/cumbersome in such environments, because they are conflicting. If it is possible to avoid this upstream that would help a lot.

To my understanding pydotplus was an intermediate fork which has not seen activity since 2014. The principal contributer to pydotplus (@carlos-jenkins) now contributes to pydot.

@trungdong
Copy link
Owner

@petrrr,

Thank you for the. I did a quick test with the latest pydot version and it seems to work fine.

Will commit the changes soon.

@ghisvail
Copy link
Contributor

+1 @petrrr, same rationales regarding the Debian packaging. A new release with the latest changes would be nice.

trungdong added a commit that referenced this issue Jul 18, 2017
* Replaced pydotplus with pydot (see #111)
* Fixed datetime and bundle error in RDF serialisation
* Tested against Python 3.6
* Improved documentation
dhimmel added a commit to dhimmel/connectivity-search-backend that referenced this issue Nov 2, 2018
It seems that pydot is now preferred over pydotplus
trungdong/prov#111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants