Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter for xml #523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add linter for xml #523

wants to merge 1 commit into from

Conversation

pat-trunk-io
Copy link
Contributor

No description provided.

@trunk-io
Copy link

trunk-io bot commented Oct 11, 2023

⏱️ 3h 39m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests (macos-latest) 1h 30m 🟥
Linter Tests (ubuntu-latest) 1h 30m 🟥
Windows Linter Tests 34m 🟥
CodeQL-Build 2m 🟩
Trunk Check runner [linux] 1m 🟩
Trunk Check 53s 🟩
Repo Tests / Plugin Tests 46s 🟩
Detect changed files 9s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Comment on lines +22 to +32
files:
- typescript
- yaml
- css
- sass
- html
- markdown
- json
- javascript
- graphql
- prettier_supported_configs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, this is correct. But just wanted to call out that we may see a couple reports when people upgrade because I know a handful of people overrode prettier filetypes in order to support some of the prettier plugins

batch: true
in_place: true
formatter: true
version: ">=3.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling out for posterity that the latest @prettier/plugin-xml only works on prettier >=3.0.0, and you have to manually downgrade in order to support older versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants