fix: create parent dirs for dist folder if don't exist #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #826
there two more places where we still use
create_dir
instead ofcreate_dir_all
here. maybe we want to fix those as well? and ideally have a linting rule to always usecreate_dir_all
instead ofcreate_dir
as we already use a mix of both accross the repo.steps to reproduce
cargo build
examples/yew
dist
value inexamples/yew/Trunk.toml
to something likedist = "dist/sub"
.../../target/debug/trunk build
on
main
you should get the error that parent dir doesn't exists.on this branch, the parent dir should be created and the build passes.