Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bucket policy for new AWS Regions #322

Merged
merged 3 commits into from
Jan 18, 2025
Merged

fix: bucket policy for new AWS Regions #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d54918
Fix bucket policy for new AWS Regions
alexandervasylev Aug 30, 2024
358f617
chore additional regions
esacteksab Jan 18, 2025
c7cf8ad
Merge branch 'main' into fix-issue-314
esacteksab Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .terraform.lock.hcl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 13 additions & 4 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
locals {
# The bucket policy that you'll use depends on the AWS Region of the bucket. Each expandable section in
# https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-access-logs.html#attach-bucket-policy
# contains a bucket policy and information about when to use that policy.
is_region_after_082022 = contains(
["ap-south-2", "ap-southeast-4", "ap-southeast-5", "ap-southeast-7", "ca-west-1", "eu-south-2", "eu-central-2", "il-central-1", "me-central-1"], data.aws_region.current.name)
}

# Get the account id of the AWS ALB and ELB service account in a given region for the
# purpose of whitelisting in a S3 bucket policy.
data "aws_elb_service_account" "main" {
count = local.is_region_after_082022 == true ? 0 : 1
}

# The AWS account id
Expand Down Expand Up @@ -266,8 +275,8 @@ data "aws_iam_policy_document" "main" {
sid = "elb-logs-put-object"
effect = local.elb_effect
principals {
type = "AWS"
identifiers = [data.aws_elb_service_account.main.arn]
type = local.is_region_after_082022 == true ? "Service" : "AWS"
identifiers = local.is_region_after_082022 == true ? ["logdelivery.elasticloadbalancing.amazonaws.com"] : [data.aws_elb_service_account.main.0.arn]
}
actions = ["s3:PutObject"]
resources = local.elb_resources
Expand All @@ -281,8 +290,8 @@ data "aws_iam_policy_document" "main" {
sid = "alb-logs-put-object"
effect = local.alb_effect
principals {
type = "AWS"
identifiers = [data.aws_elb_service_account.main.arn]
type = local.is_region_after_082022 == true ? "Service" : "AWS"
identifiers = local.is_region_after_082022 == true ? ["logdelivery.elasticloadbalancing.amazonaws.com"] : [data.aws_elb_service_account.main.0.arn]
}
actions = ["s3:PutObject"]
resources = local.alb_resources
Expand Down
Loading