Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove CLS VC Wrapper database (S3) #1230

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Apr 4, 2023

For S3 remove underlying VC Wrapper database.

Closes #1229

@cla-bot cla-bot bot added the cla-signed label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.02 ⚠️

Comparison is base (96f66c1) 88.57% compared to head (f998cb5) 88.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   88.57%   88.55%   -0.02%     
==========================================
  Files         115      115              
  Lines        7247     7236      -11     
==========================================
- Hits         6419     6408      -11     
  Misses        536      536              
  Partials      292      292              
Impacted Files Coverage Δ
cmd/vc-rest/startcmd/start.go 76.18% <50.00%> (-0.05%) ⬇️
pkg/storage/s3/cslvcstore/csl_vc_store.go 88.88% <100.00%> (-1.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

For S3 remove underlying VC Wrapper database.

Closes trustbloc#1229

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@bstasyszyn bstasyszyn merged commit a3b0152 into trustbloc:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CSL Wrapper Store
3 participants