Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove last afgo and orb dependencies #1410

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Sep 8, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 8, 2023
@Moopli Moopli marked this pull request as ready for review September 8, 2023 20:29
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b22523b) 85.35% compared to head (d35ea62) 85.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1410   +/-   ##
=======================================
  Coverage   85.35%   85.35%           
=======================================
  Files         162      162           
  Lines       10234    10234           
=======================================
  Hits         8735     8735           
  Misses       1092     1092           
  Partials      407      407           
Files Changed Coverage Δ
pkg/lifecycle/lifecycle.go 93.75% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -180,13 +180,7 @@ clean:

.PHONY: update-aries
update-aries:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this target just be removed completely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's used elsewhere, so I've left it with a deprecation notice for now.

@@ -0,0 +1,661 @@
/*
Copyright SecureKey Technologies Inc. All Rights Reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyrights should be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Signed-off-by: Filip Burlacu <Filip.Burlacu@gendigital.com>
@rolsonquadras rolsonquadras merged commit 416d07c into trustbloc:main Sep 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants