Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge main #1599

Merged

Conversation

mishasizov-SK
Copy link
Contributor

No description provided.

bstasyszyn and others added 8 commits January 24, 2024 14:12
Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
…-attestations

feat: Add option for attestation request in wallet CLI attestation client
Signed-off-by: Andrii Holovko <andriy.holovko@gmail.com>
fix: use issuer DID instead of URL when validating issuer
Allow to substitute the default trust-registry client.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
…c#1597)

Policy checks during presentation are now performed regardless of whether attestation checks are enabled, if the policy URL is configured. The policy URL is now configured against the policy check type.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
…oc#1598)

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (977063e) 85.44% compared to head (d3fc3db) 85.45%.

Files Patch % Lines
pkg/service/trustregistry/trustregistry_service.go 82.97% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           OIDC4VCI_ID1    #1599      +/-   ##
================================================
+ Coverage         85.44%   85.45%   +0.01%     
================================================
  Files               172      172              
  Lines             11386    11408      +22     
================================================
+ Hits               9729     9749      +20     
- Misses             1204     1205       +1     
- Partials            453      454       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mishasizov-SK mishasizov-SK merged commit 9a26871 into trustbloc:OIDC4VCI_ID1 Feb 16, 2024
10 checks passed
@mishasizov-SK mishasizov-SK deleted the OIDC4VCI_ID1_merge branch February 26, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants