Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: generate cyclonedx sboms during the build #546

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Jul 15, 2024

Also: use GITHUB_TOKEN for cargo binstall to avoid GH API rate limits

Closes #534

@ctron ctron requested a review from bobmcwhirter July 15, 2024 12:31
@ctron
Copy link
Contributor Author

ctron commented Jul 15, 2024

Not sure it's a "good" SBOM. But it is one.

@bobmcwhirter
Copy link
Contributor

Seems there's some leakage of build machine details?

    {
      "type": "library",
      "bom-ref": "path+file:///Users/bob/repos/trustification/trustify/modules/importer#trustify-module-importer@0.1.0-alpha.11",
      "name": "trustify-module-importer",
      "version": "0.1.0-alpha.11",
      "scope": "required",
      "purl": "pkg:cargo/trustify-module-importer@0.1.0-alpha.11?download_url=file%253A%252F%252F..%25252Fmodules%25252Fimporter"
    },

Any way to ... make that less leaky?

@ctron
Copy link
Contributor Author

ctron commented Jul 15, 2024

You mean that part?

"bom-ref": "path+file:///Users/bob/repos/trustification/trustify/modules/importer#trustify-module-importer@0.1.0-alpha.11",

Indeed, that feels a bit weird. But it's something we'd need to address with the cargo plugin. Which is fine, I contributed before.

@ctron
Copy link
Contributor Author

ctron commented Jul 15, 2024

The question is, is that a blocker for us?

@bobmcwhirter
Copy link
Contributor

Nah, just a comment.

@ctron ctron added this pull request to the merge queue Jul 15, 2024
Merged via the queue into trustification:main with commit 7ebe430 Jul 15, 2024
3 checks passed
@ctron ctron deleted the feature/create_sbom_1 branch July 15, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Good Quality SBOM for Trustify, continuously.
2 participants