Update build commands for scikit-build #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld enabled Python builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Python build commands for projects currently enabled to use scikit-build. Note that it includes an update for cudf since the cudf scikit-build update is currently in progress (rapidsai/cudf#10919) so we probably should hold off merging this until that PR is merged. If rmm/raft/cuspatial Python developers making use of compose are currently experiencing the new build system as a pain point, though, we can undo the cudf changes and get this PR merged for the projects that have already transitioned to scikit-build (rmm, raft, and cuspatial). I don't expect the minor delay in getting this merged to be a major issue though since a) librmm is header-only, so the Python build isn't slowed down at all by "separately" building librmm, b) raft devs don't really seem to be using rapids-compose, and c) most active cuspatial dev is currently in C++ (and docs).
Partially addresses #66. I'll make follow-up PRs once the conversions for cugraph and cuML are completed.