Feature/show routes based off checkboxes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddyIonescu
approved these changes
Dec 9, 2017
| @import url('https://fonts.googleapis.com/css?family=Poppins'); | ||
|
|
||
| body { | ||
| font-family: 'Poppins', sans-serif; |
| padding: 0; | ||
| } | ||
|
|
| }; | ||
| } | ||
|
|
||
| componentWillMount() { |
There was a problem hiding this comment.
If possible, let's use componentDidMount as then it'll only run once - and it's better practice to initialize things (lines 43 and 45) in the constructor. See facebook/react#7671
| zoom: 15, | ||
| pitch: 0, | ||
| bearing: 0, | ||
| }, |
There was a problem hiding this comment.
this makes the zoom in/out disappear - make sure this works before merging
There was a problem hiding this comment.
Ahh! Sorry for the lag. Will fix this ASAP!
| @@ -11,6 +11,7 @@ | |||
| "babel-loader": "7.1.1", | |||
| "babel-preset-react-app": "^3.0.3", | |||
| "babel-runtime": "6.26.0", | |||
| "bootstrap": "4.0.0-beta", | |||
There was a problem hiding this comment.
Could you describe in the PR how adding bootstrap/reactstrap is useful? (is it to make the sidebar prettier?)
EddyIonescu
added a commit
that referenced
this pull request
Jan 17, 2018
Thanks to trynmaps/tryn-api#14 the client now has to change its Relay schema as to correspond to the new format. The reason such a change is needed is because it's necessary to do the things we want, like only get data corresponding to open routes or better handle the drawing of each route. Now that the states are inside a route, we can choose to request the vehicles ONLY for the routes that are selected - which is a big performance gain. At the same time, only a handful of routes will be open at a time, and there's another PR that will let the user choose which ones (#24). However, while the client works - it only displays the state for the first route. The next step is to have a layer for each route, that contains all of its states - which is a TODO described here: #27 Tests: - manually opened web app and dragged around. Worked as expected.
added 4 commits
January 17, 2018 02:22
EddyIonescu
force-pushed
the
feature/Show_Routes_Based_Off_Checkboxes
branch
from
b46caf5
to
64425ef
Compare
EddyIonescu
added a commit
that referenced
this pull request
Jan 17, 2018
Thanks to trynmaps/tryn-api#14 the client now has to change its Relay schema as to correspond to the new format. The reason such a change is needed is because it's necessary to do the things we want, like only get data corresponding to open routes or better handle the drawing of each route. Now that the states are inside a route, we can choose to request the vehicles ONLY for the routes that are selected - which is a big performance gain. At the same time, only a handful of routes will be open at a time, and there's another PR that will let the user choose which ones (#24). However, while the client works - it only displays the state for the first route. The next step is to have a layer for each route, that contains all of its states - which is a TODO described here: #27 Tests: - manually opened web app and dragged around. Worked as expected.
EddyIonescu
added a commit
that referenced
this pull request
Jan 20, 2018
Thanks to trynmaps/tryn-api#14 the client now has to change its Relay schema as to correspond to the new format. The reason such a change is needed is because it's necessary to do the things we want, like only get data corresponding to open routes or better handle the drawing of each route. Now that the states are inside a route, we can choose to request the vehicles ONLY for the routes that are selected - which is a big performance gain. At the same time, only a handful of routes will be open at a time, and there's another PR that will let the user choose which ones (#24). However, while the client works - it only displays the state for the first route. The next step is to have a layer for each route, that contains all of its states - which is a TODO described here: #27 Tests: - manually opened web app and dragged around. Worked as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Front end piece which includes:
It needs a lot of CSS TLC but the structure is here.
rev: @EddyIonescu