Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"On-Screen-Menu- Buttons" do not react to Android Dark Mode #556

Closed
Watson15683 opened this issue Mar 12, 2021 · 1 comment
Closed

"On-Screen-Menu- Buttons" do not react to Android Dark Mode #556

Watson15683 opened this issue Mar 12, 2021 · 1 comment
Labels
always-fresh Issues that will never become stale bug Something isn't working priority/low

Comments

@Watson15683
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The "On-Screen-Menu" does not react to dark mode. After having activated dark mode the "On-Screen-Menu" stays white.

This is how the noice-App it looks like with Dark Mode activated:
grafik

This is how i think it is supposed to look like (Screenshot taken from the Nextcloud-App in Dark mode)
grafik

to replicate

  1. Have a Phone with "On-Screen-Menu"
  2. activate Dark Mode
  3. Look at the "On-Screen-Menu"

Describe the solution you'd like

Id like the app to change the colour of the "On-Screen-Menu", when the Dark mode is activated, to the background colour of the app. Because the white colour is not that pleasing on the eyes at night.

Additional Information

  • Device: Samsung Galaxy M21
  • Android Version: Android 10
  • One UI Core-Version: 2.5
  • App Version: 0.15.0 (F-Droid)
@Watson15683 Watson15683 added the enhancement New feature or request label Mar 12, 2021
@ashutoshgngwr
Copy link
Member

Likely happening due to the dark action bar feature. Earlier, the navigation bar used to translucent, but that had to change in light of #484. Now I am thinking of removing the dark action bar feature altogether, and making it a light action bar with the light theme variant and dark action bar with the dark theme variant.

@ashutoshgngwr ashutoshgngwr added always-fresh Issues that will never become stale bug Something isn't working priority/low and removed enhancement New feature or request labels Mar 13, 2021
ashutoshgngwr added a commit that referenced this issue Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
always-fresh Issues that will never become stale bug Something isn't working priority/low
Projects
None yet
Development

No branches or pull requests

2 participants