Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation for missing text items. #244

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

GilgusMaximus
Copy link
Contributor

Changes

Added the german translations for the missing items from #200 .

Testing

  • Not done yet. Could not build on my setup yet.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #244 into master will decrease coverage by 12.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #244       +/-   ##
===========================================
- Coverage   97.79%   85.37%   -12.42%     
===========================================
  Files           3       26       +23     
  Lines         136     1272     +1136     
  Branches       30      147      +117     
===========================================
+ Hits          133     1086      +953     
- Misses          3       89       +86     
- Partials        0       97       +97     
Flag Coverage Δ
#android 85.37% <100.00%> (?)
#cast_receiver ?
#ui_tests 63.06% <100.00%> (?)
#unit_tests 40.15% <0.00%> (-57.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.40% <100.00%> (ø)
cast-receiver/src/player_manager.ts
cast-receiver/src/status_ui_handler.ts
cast-receiver/src/library.mock.js
.../main/java/com/github/ashutoshgngwr/noice/Utils.kt 33.33% <0.00%> (ø)
...hub/ashutoshgngwr/noice/fragment/DialogFragment.kt 83.87% <0.00%> (ø)
...ithub/ashutoshgngwr/noice/widget/DurationPicker.kt 76.92% <0.00%> (ø)
...ub/ashutoshgngwr/noice/cast/CastOptionsProvider.kt 85.71% <0.00%> (ø)
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 78.04% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030e767...cb696c6. Read the comment docs.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution. 👍

@ashutoshgngwr ashutoshgngwr merged commit 5fa0116 into trynoice:master Jul 23, 2020
@GilgusMaximus
Copy link
Contributor Author

Yeah sure. Thanks for the app ! It is really great, so I contributed what I had time for.
If some new strings are implemented, I'll try to update the translations when I receive the notification.

@ashutoshgngwr ashutoshgngwr added this to the 0.9.x milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants