Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts PR #330 to downgrade ExoPlayer to 2.11.8 #345

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

Some recent change in ExoPlayer is causing gaps in looping sounds. Reverting to provide a temporary fix for issue #344.

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

…ayer-exoplayer-core-2.12.0'

This reverts commit 3e50f6b, reversing
changes made to ab1c105.
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #345 into master will increase coverage by 16.73%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #345       +/-   ##
=============================================
+ Coverage     70.14%   86.88%   +16.73%     
=============================================
  Files            30       30               
  Lines          1611     1616        +5     
  Branches        178      178               
=============================================
+ Hits           1130     1404      +274     
+ Misses          401      114      -287     
- Partials         80       98       +18     
Flag Coverage Δ Complexity Δ
#android 86.16% <ø> (+18.17%) 0.00 <ø> (-12.00) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...hub/ashutoshgngwr/noice/fragment/DialogFragment.kt 84.37% <0.00%> (-7.16%) 0.00% <0.00%> (ø%)
cast-receiver/src/library.mock.ts 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 99.58% <0.00%> (+0.41%) 0.00% <0.00%> (ø%)
cast-receiver/src/status_ui_handler.ts 97.43% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ub/ashutoshgngwr/noice/widget/CountdownTextView.kt 83.78% <0.00%> (+2.70%) 0.00% <0.00%> (ø%)
cast-receiver/src/player_manager.ts 94.18% <0.00%> (ø) 0.00% <0.00%> (ø%)
...hub/ashutoshgngwr/noice/widget/MarkdownTextView.kt 44.44% <0.00%> (+11.11%) 0.00% <0.00%> (ø%)
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 93.18% <0.00%> (+20.45%) 0.00% <0.00%> (ø%)
...ithub/ashutoshgngwr/noice/widget/DurationPicker.kt 76.92% <0.00%> (+34.61%) 0.00% <0.00%> (ø%)
...m/github/ashutoshgngwr/noice/WakeUpTimerManager.kt 75.00% <0.00%> (+36.11%) 0.00% <0.00%> (ø%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3523b4e...89ad85a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant