Add Indonesian translation #369
Conversation
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 86.93% 86.96% +0.02%
==========================================
Files 30 30
Lines 1623 1626 +3
Branches 178 178
==========================================
+ Hits 1411 1414 +3
Misses 114 114
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @imanudinsh
Thank you for taking the time to translate Noice to Indonesian. I have requested a few changes. Please have a look. In addition to those changes, if you could also remove the region codes from all file paths. On Android, it will work but is not required since Indonesian is only spoken in Indonesia. In Fastlane metadata, it will not work since Google Play only recognises id tag. So to sum it up,
- Rename
values-in-rIDtoin - Rename
fastlane/metadata/android/in-IDtofastlane/metadata/android/id
| @@ -0,0 +1 @@ | |||
| Santai, tingkatkan fokus, dan tingkatkan produktivitas dengan derau pelataran minimal. | |||
There was a problem hiding this comment.
The short description needs to be 80 characters at most. It's 86 right now. Can you please rephrase it to be <= 80?
| <string name="preset_already_exists">Preset dengan nama yang diberikan sudah ada!</string> | ||
| <string name="preset_saved">Preset disimpan!</string> | ||
| <string name="saved_presets">Preset Tersimpan</string> | ||
| <string name="preset_delete_confirmation">Konfirmasi hapus% s?</string> |
There was a problem hiding this comment.
There's a typo here.
| <string name="preset_delete_confirmation">Konfirmasi hapus% s?</string> | |
| <string name="preset_delete_confirmation">Konfirmasi hapus %s?</string> |
| pengatur waktu. | ||
| </string> | ||
| <string name="reset">Setel ulang</string> | ||
| <string name="auto_sleep_schedule_cancelled">Pengatur waktu tidur otomatis dibatalkan!</string> |
There was a problem hiding this comment.
Google translates it to Sleep timer automatically canceled! but it needs to imply Sleep timer cancelled! or Automatic sleep timer cancelled!
|
Hello @ashutoshgngwr, Thanks for reviewing my pull request, I'll fix it and come back asap |
|
Hi @ashutoshgngwr, I've fixed typos, updated translations, and changed the region code on all file paths. |
Changes
Add Indonesian translation
Testing
Others