Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in Brazilian Portuguese translations #381

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

lucastsantos
Copy link
Contributor

Changes

This PR adds translations for missing items. I also took the liberty to change some terms that was already translated to terms that are commonly used by other apps.

Those are:

  • Library: "Biblioteca" alone is commonly used by many music players, so I felt that there's no need to provide more details for the user
  • Sleep timer: "Temporizador" (pt-br) or just "Timer" (english word, but a known word to brazilians nowadays) is commonly used by music players to provide this same feature. I've aligned with the spanish translation to keep as Temporizador.

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files          30       30           
  Lines        1626     1626           
  Branches      178      178           
=======================================
  Hits         1414     1414           
  Misses        114      114           
  Partials       98       98           
Flag Coverage Δ
#android 86.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925ead6...3142e00. Read the comment docs.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, this is great work!

@ashutoshgngwr ashutoshgngwr merged commit 59ed0ec into trynoice:master Oct 17, 2020
@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented Oct 17, 2020

@lucastsantos I forgot to mention. Can you please also update Fastlane metadata for pt-BR? I think it is also outdated.


And also your name to Translation credits. :)

@lucastsantos
Copy link
Contributor Author

Thanks, glad to help!
Sure, i'll take a look at it and add the credits aswell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants