Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds generate random preset action button #424

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

ashutoshgngwr
Copy link
Member

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #424 (edd94da) into master (2b2f4dd) will increase coverage by 0.31%.
The diff coverage is 91.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   87.00%   87.32%   +0.31%     
==========================================
  Files          30       30              
  Lines        1624     1688      +64     
  Branches      178      182       +4     
==========================================
+ Hits         1413     1474      +61     
- Misses        113      117       +4     
+ Partials       98       97       -1     
Flag Coverage Δ
android 86.67% <91.75%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hutoshgngwr/noice/fragment/SoundLibraryFragment.kt 88.15% <82.60%> (+1.43%) ⬆️
...hub/ashutoshgngwr/noice/fragment/DialogFragment.kt 84.12% <100.00%> (-0.25%) ⬇️
...ava/com/github/ashutoshgngwr/noice/sound/Preset.kt 92.85% <100.00%> (ø)
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 99.62% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2f4dd...edd94da. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit a781910 into master Dec 1, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/random-preset branch December 1, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant