Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turkish translatiın #428

Merged
merged 10 commits into from
Dec 7, 2020
Merged

Add Turkish translatiın #428

merged 10 commits into from
Dec 7, 2020

Conversation

berkaygunduzz
Copy link
Contributor

@berkaygunduzz berkaygunduzz commented Dec 7, 2020

Changes

Followed instructions for Turkish translate

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #428 (fce3314) into master (15acf89) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   85.40%   85.42%   +0.02%     
==========================================
  Files          32       32              
  Lines        1781     1784       +3     
  Branches      227      227              
==========================================
+ Hits         1521     1524       +3     
  Misses        119      119              
  Partials      141      141              
Flag Coverage Δ
android 84.67% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.21% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15acf89...fce3314. Read the comment docs.

@berkaygunduzz
Copy link
Contributor Author

@ashutoshgngwr Why it's failed?

@ashutoshgngwr
Copy link
Member

@berkaygunduzz Still running UI tests. Should pass after that.

@berkaygunduzz
Copy link
Contributor Author

Then ok, waiting.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few minor changes. Everything else looks great. Nice work!

Comment on lines 143 to 149
<string name="appintro__timer_title">Uyumakta veya uyanmakta zorluk mu çekiyorsunuz?</string>
<string name="appintro__timer_desc">
Ufak bir ambiyans sizin uyumanızda zahmetsizce yardımcı olabilir. Uyku
Zamanlayıcı kullanarak Noice\'in sesi kendiliğinden kesmesini sağlayabilirsiniz.
Benzer şekilde sakin bir ortamda uyanmak için Uyandırma Zamanlayıcı kullanarak
alarmı ayarlayabilirsiniz
</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to shorten these texts, somehow? These look awfully long and the title is getting trimmed on emulator screen.

2020-12-07_19-27

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try, just give me a little time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it's not word by word translation, but gives similar meaning.
For example now title says "Are you having problems about sleep?"

Copy link
Contributor Author

@berkaygunduzz berkaygunduzz Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it gives me an error while one line was too long? I fixed it but what's it about?

fastlane/metadata/android/tr/full_description.txt Outdated Show resolved Hide resolved
Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ashutoshgngwr ashutoshgngwr merged commit 6c6125d into trynoice:master Dec 7, 2020
ashutoshgngwr added a commit that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants