-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Turkish translatiın #428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 85.40% 85.42% +0.02%
==========================================
Files 32 32
Lines 1781 1784 +3
Branches 227 227
==========================================
+ Hits 1521 1524 +3
Misses 119 119
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@ashutoshgngwr Why it's failed? |
@berkaygunduzz Still running UI tests. Should pass after that. |
Then ok, waiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a few minor changes. Everything else looks great. Nice work!
<string name="appintro__timer_title">Uyumakta veya uyanmakta zorluk mu çekiyorsunuz?</string> | ||
<string name="appintro__timer_desc"> | ||
Ufak bir ambiyans sizin uyumanızda zahmetsizce yardımcı olabilir. Uyku | ||
Zamanlayıcı kullanarak Noice\'in sesi kendiliğinden kesmesini sağlayabilirsiniz. | ||
Benzer şekilde sakin bir ortamda uyanmak için Uyandırma Zamanlayıcı kullanarak | ||
alarmı ayarlayabilirsiniz | ||
</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try, just give me a little time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it's not word by word translation, but gives similar meaning.
For example now title says "Are you having problems about sleep?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it gives me an error while one line was too long? I fixed it but what's it about?
Co-authored-by: Ashutosh Gangwar <ashutoshgngwr@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Changes
Followed instructions for Turkish translate