Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE GERMAN TRANSLATION #446

Merged
merged 3 commits into from
Dec 10, 2020

Conversation

MakiWolf
Copy link
Contributor

@MakiWolf MakiWolf commented Dec 9, 2020

Changes

I am quit new here, but I have improved a little bit the German translation

Testing

  • Tested on a physical device
  • Added or modified unit test cases

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #446 (378b2cd) into master (c8e5781) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
+ Coverage   85.42%   85.45%   +0.02%     
==========================================
  Files          32       32              
  Lines        1784     1787       +3     
  Branches      227      227              
==========================================
+ Hits         1524     1527       +3     
  Misses        119      119              
  Partials      141      141              
Flag Coverage Δ
android 84.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.23% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e5781...378b2cd. Read the comment docs.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MakiWolf

While I appreciate the effort, you've only added four missing strings when many of them are missing. Please take a look at #200 and consider adding more translations for me to consider merging this.

@MakiWolf
Copy link
Contributor Author

I have add more GERMAN TRANSLATION in this commit ff5546c, but I am quiet new and think that I have made something false when pushing that to Github.

@ashutoshgngwr
Copy link
Member

@MakiWolf I noticed the issue and fixed it.

PS, if someone else (besides you) pushes a commit to a pull request (or a branch in general), you have to perform git pull before pushing again to avoid the issue that you encountered.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions. There are still missing translations. If you'd like to add them, consider making another pull request.

PS, sync master branch of your fork before making any changes.

git checkout master
git pull https://github.com/ashutoshgngwr/noice.git master

@ashutoshgngwr ashutoshgngwr merged commit 51b94d7 into trynoice:master Dec 10, 2020
@MakiWolf MakiWolf deleted the GERMAN_TRANSLATION branch February 5, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants