fix(app): Solve text being cut off on small devices! #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
- Coverage 48.48% 47.78% -0.70%
==========================================
Files 32 33 +1
Lines 1844 1871 +27
Branches 179 180 +1
==========================================
Hits 894 894
- Misses 903 930 +27
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Comment on lines
8
to
9
| android:paddingTop="@dimen/appintro_statusbar_height" | ||
| android:paddingBottom="@dimen/appintro2_bottombar_height" |
There was a problem hiding this comment.
Can we also add some horizontal padding? I noticed one heading fitting itself right to the edges.
There was a problem hiding this comment.
Sure, I think 20dp of horizontal padding is enough, right?
android:paddingStart="20dp"
android:paddingEnd="20dp"
…ml and change its name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a Custom Fragment with a custom layout to solve text being cut off on small devices. This fragment has the exact same name that had the AppIntro library for its fragment, so you won't notice a change there.
Others