Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user setting to disable media buttons #796

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Conversation

ashutoshgngwr
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #796 (270cad3) into main (d13ce3a) will decrease coverage by 0.54%.
The diff coverage is 22.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #796      +/-   ##
============================================
- Coverage     75.57%   75.02%   -0.55%     
  Complexity       15       15              
============================================
  Files            55       55              
  Lines          2596     2603       +7     
  Branches        410      416       +6     
============================================
- Hits           1962     1953       -9     
- Misses          317      332      +15     
- Partials        317      318       +1     
Flag Coverage Δ
android 74.02% <22.58%> (-0.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 63.79% <0.00%> (ø)
...thub/ashutoshgngwr/noice/playback/PlayerManager.kt 67.94% <0.00%> (-1.33%) ⬇️
...hutoshgngwr/noice/repository/SettingsRepository.kt 81.81% <0.00%> (-9.10%) ⬇️
...hgngwr/noice/playback/PlayerNotificationManager.kt 65.00% <29.41%> (-17.76%) ⬇️
...ashutoshgngwr/noice/playback/PlaybackController.kt 90.99% <100.00%> (+0.08%) ⬆️
...hutoshgngwr/noice/fragment/RandomPresetFragment.kt 62.06% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13ce3a...270cad3. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit de79408 into main Sep 6, 2021
@ashutoshgngwr ashutoshgngwr deleted the fix/issue-972 branch September 6, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluetooth earphones control does not respect "Allow skipping unsaved presets".
1 participant