Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated czech translation #802

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Updated czech translation #802

merged 2 commits into from
Sep 17, 2021

Conversation

tajnymag
Copy link
Contributor

Changes

  • sorted czech strings.xml to be in the same order as the original one
  • added new translations to stay in sync
  • changed the czech translation of "Preset" to be "Mix" instead of "Předvolba" as the current translation points more towards a "Settings" meaning then a sound preset
  • fixed a typo

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

* sorted czech strings.xml to be in the same order as the original one
* added new translations to stay in sync
* changed the czech translation of "Preset" to be "Mix" instead of "Předvolba" as the current translation points more towards a "Settings" meaning then a sound preset
* fixed a typo
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #802 (3ae90ba) into main (8b46e03) will decrease coverage by 29.82%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##               main     #802       +/-   ##
=============================================
- Coverage     74.93%   45.10%   -29.83%     
=============================================
  Files            54       54               
  Lines          2665     2627       -38     
  Branches        428      417       -11     
=============================================
- Hits           1997     1185      -812     
- Misses          345     1314      +969     
+ Partials        323      128      -195     
Flag Coverage Δ
android 42.44% <ø> (-31.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/com/github/ashutoshgngwr/noice/ext/UriExt.kt 0.00% <0.00%> (-100.00%) ⬇️
...r/noice/provider/InAppBillingDonateViewProvider.kt 0.00% <0.00%> (-100.00%) ⬇️
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 0.00% <0.00%> (-97.83%) ⬇️
...b/ashutoshgngwr/noice/activity/AppIntroActivity.kt 0.00% <0.00%> (-97.23%) ⬇️
...oshgngwr/noice/activity/ShortcutHandlerActivity.kt 0.00% <0.00%> (-81.82%) ⬇️
...ub/ashutoshgngwr/noice/fragment/LibraryFragment.kt 0.00% <0.00%> (-79.49%) ⬇️
...ub/ashutoshgngwr/noice/fragment/PresetsFragment.kt 0.00% <0.00%> (-76.00%) ⬇️
...ashutoshgngwr/noice/provider/DonateViewProvider.kt 0.00% <0.00%> (-75.00%) ⬇️
...gngwr/noice/fragment/SupportDevelopmentFragment.kt 0.00% <0.00%> (-68.75%) ⬇️
...shutoshgngwr/noice/fragment/WakeUpTimerFragment.kt 0.00% <0.00%> (-68.19%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b46e03...3ae90ba. Read the comment docs.

Copy link
Member

@ashutoshgngwr ashutoshgngwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tajnymag! This looks good.

A gentle reminder that we have moved our translation workflow to Weblate. Things are much easier to manage there. We've also switched our default branch to main.

I see a few outdated keys. I'll fix them myself. I am about to create a release, so I might as well merge this into it.

@ashutoshgngwr ashutoshgngwr changed the base branch from master to main September 17, 2021 17:48
@tajnymag
Copy link
Contributor Author

tajnymag commented Sep 17, 2021

I know about Weblate. The trouble is, I was not able to translate any key through it's interface. Whenever I filled the form, confirmed/saved the translation, after a refresh, the translation form was clean again without any sign of my impact. As was the statistic of translated keys.

That's why I said myself "screw it" and did the translating manually as I did before.

@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented Sep 17, 2021

Whenever I filled the form, confirmed/saved the translation, after a refresh, the translation form was clean again without any sign of my impact.

@tajnymag That's my bad! I've set the option to add translations as suggestions. So when you were adding new strings, they were being added as suggestions that I can review and merge. Or if they have more than two votes, they get automatically merged. I'll disable that option. I've been told me this exact thing via email once. 😅

Edit: I've enabled direct editing. Maybe you can let me know if it works.

@ashutoshgngwr ashutoshgngwr merged commit 32fb276 into trynoice:main Sep 17, 2021
@tajnymag
Copy link
Contributor Author

Awesome. Thanks. If it's OK, I'll try it tomorrow morning and will let you know.

@tajnymag
Copy link
Contributor Author

Seems to be working now. Thank you.

However, I've encountered two issues that I'd like to discuss.

  1. Before I was able to properly edit the translations, I had managed to create a new duplicate glossary item with a blank key which I am unable to delete by myself. Or at least haven't found the way.

obrazek

  1. Does Weblate update the repo strings in both ways? It seems the manually translated strings from this PR haven't gotten projected to Weblate yet.

@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented Sep 18, 2021

@tajnymag

  1. Fixed
  2. It syncs repo both ways. The changes should be there. I had to remove a few strings because you were translating on master which was about a hundred commits behind main.

@tajnymag
Copy link
Contributor Author

  1. Great. Sorry.
  2. Ah, ok. I'll translate them again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants