Store all integration test results on repo #440
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeake
force-pushed
the
ci_outputs
branch
2 times, most recently
from
113efa7
to
d3e39f3
Compare
aspeake
changed the title
aspeake
commented
Nov 15, 2024
| @@ -73,6 +74,7 @@ jobs: | |||
| git pull origin $branch_name | |||
| git add ./tests/integration_testing/results/*.json | |||
| if [[ $(git diff --cached --exit-code) ]]; then | |||
| git add ./tests/integration_testing/results | |||
There was a problem hiding this comment.
If there are any changes to the results jsons, then add all outputs
aspeake
force-pushed
the
ci_outputs
branch
2 times, most recently
from
8634a2e
to
a7c467e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to support fixing #415
This PR updates the integration test artifacts outputs to include all data in the results directory when running on GitHub Actions. Those results files, which include the existing agg_results.json and ecm_results.json files and the additional data in results/plots, are now stored on the repo for better comparisons between master and feature branches.
This initial PR is required so that 1) we have plots on master that can be compared to new plots from a feature branch and 2) a follow-on PR can pull down the .json and .xlsx data from master to generate more readable comparisons.